Comments on: No more excuses: junit testing log messages

By: Andrea Cerisara

Andrea Cerisara — Thu, 22 Oct 2009 19:36:43 +0000

To clarify myself, for example (without interface, using an object seam): in LoggingObject

protected Logger logger()
{
    return Logger.getLogger(LoggingObject.class);
}

public void starts()
{
    logger().info("I'm starting");
}

in ALoggingObject

private Logger logger;

@Before
public void setUp()
{
    logger = mock(Logger.class);
    loggingObject = new LoggingObject()
    {
        @Override
        public Logger logger()
        {
            return logger;
        }
    };
}

@Test
public void shouldLogWhenStarts()
{
    loggingObj.starts();
    verify(logger).info("I'm starting");
}

By: Andrea Cerisara

Andrea Cerisara — Thu, 22 Oct 2009 19:15:20 +0000

That’s true, but you have a static dependency that, in my opinion, makes hard to test your object. Just a thought anyway

By: giordano scalzo

giordano scalzo — Thu, 22 Oct 2009 15:39:32 +0000

mmm
in fact RecordingAppender it’s just a kind of test double
I agree with you, that injecting that responsibility should be more clear.

Thanks for your suggestion

By: Andrea Cerisara

Andrea Cerisara — Thu, 22 Oct 2009 14:07:28 +0000

Correct me if I’m wrong, but it seems to me that LoggingObject is a business object: in that case I would probably extract the logging functionality to an interface and test it through an interaction test with some kind of test double.